docs: pin chai to version 4 in browser example#5230
Merged
JoshuaKGoldberg merged 1 commit intomochajs:mainfrom Oct 13, 2024
Merged
docs: pin chai to version 4 in browser example#5230JoshuaKGoldberg merged 1 commit intomochajs:mainfrom
JoshuaKGoldberg merged 1 commit intomochajs:mainfrom
Conversation
The committers listed above are authorized under a signed CLA. |
JoshuaKGoldberg
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
I pinned
chaito version 4 in the browser example. Since chai@5, the assertion library is distributed as a JavaScript module and doesn't add methods to the global scope. By pinning the version to the previous version 4 we make sure that the example still works.We could update the example to use chai@5 as a module but I figure this would be a quick fix to the issue.